Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to dotnet 8 #998

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Move to dotnet 8 #998

merged 3 commits into from
Feb 11, 2025

Conversation

keyboardDrummer
Copy link
Collaborator

@keyboardDrummer keyboardDrummer commented Feb 11, 2025 •
edited
Loading

Changes

  • Rename class cce to Cce, to prevent a warning when using .NET 8
  • Move from dotnet 6 to 8

@keyboardDrummer keyboardDrummer enabled auto-merge (squash) February 11, 2025 16:06
robin-aws
robin-aws reviewed Feb 11, 2025
View reviewed changes
Copy link
Contributor

@robin-aws robin-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename class cce to Cce

...and upgrade to .Net 8? :) Is there any installation/setup documentation that should be updated too?

Source/CodeContractsExtender/cce.cs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not rename the file too?

MikaelMayer
MikaelMayer approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@MikaelMayer MikaelMayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, .net version bump and class rename is ok for me. I checked every file.

@keyboardDrummer keyboardDrummer merged commit dcfad54 into boogie-org:master Feb 11, 2025
5 checks passed
@keyboardDrummer keyboardDrummer deleted the cceRename branch February 11, 2025 17:02
@keyboardDrummer keyboardDrummer changed the title Cce rename Move to dotnet 8 Feb 13, 2025
@keyboardDrummer keyboardDrummer mentioned this pull request Feb 13, 2025
Closed
@cos cos mentioned this pull request Feb 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robin-aws robin-aws robin-aws left review comments

@MikaelMayer MikaelMayer MikaelMayer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keyboardDrummer @MikaelMayer @robin-aws